Feature 146 use any smoother for sobv #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
femtotrader
force-pushed
the
feature-146-use_any_smoother_for_sobv
branch
from
10c2884 to
a472ea4
Compare
femtotrader
commented
Jul 7, 2024
| @@ -48,13 +48,13 @@ def assertIndicatorDelete(self, indicator: Indicator, iterations_no: int = 20): | |||
| indicator.remove() | |||
|
|
|||
| # verify that adding and then removing X input values returns the original output value | |||
| self.assertEqual(last_indicator_value, indicator[-1]) | |||
| self.assertAlmostEqual(last_indicator_value, indicator[-1], places = 5) | |||
There was a problem hiding this comment.
I'm not sure about that
|
|
||
| # delete the original last input value and add it back and check the original last output value is returned | ||
| indicator.remove() | ||
| indicator.add(last_input_value) | ||
|
|
||
| self.assertEqual(last_indicator_value, indicator[-1]) | ||
| self.assertAlmostEqual(last_indicator_value, indicator[-1], places = 5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146